Post record language tagging, lexicon language format #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
approved these changes
Jun 19, 2023
|
Looks great and tests on my end work. Good to merge and publish a new api version |
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
…#1219) * Add languages field to post record * helper for parsing bcp47 * add language format to lexicon * codegen for post record langs field * re-export language parsing in api package * tests and tidy for lexicon language format * index post langs, in-progress * update snapshots, fixes record-with-media embed issue * index post langs on bsky appview * don't bother indexing post langs in pds appview, tidy
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
…#1219) * Add languages field to post record * helper for parsing bcp47 * add language format to lexicon * codegen for post record langs field * re-export language parsing in api package * tests and tidy for lexicon language format * index post langs, in-progress * update snapshots, fixes record-with-media embed issue * index post langs on bsky appview * don't bother indexing post langs in pds appview, tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
languageformat to lexicon, validated as well-formed BCP 47 language tags.langsfield to the post record, an array containing up to three languages used within the contents of the post.