-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle validation improvements #1336
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5c3687a
Handle matches and false positives for unacceptable words in handles
ericvolp12 db07e9e
move handle validation logic to pds
dholms 78b995e
merge unacceptable words validator
dholms 50639f3
missed merge
dholms 22a396d
add cfg flag
dholms 4030071
encode lists
dholms 06beb51
fix build issues
dholms 1f8ae1d
move words to cfg
dholms 6cf949f
tidy
dholms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
export * from './handle' | ||
export * from './did' | ||
export * from './reserved' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,8 @@ export interface ServerConfigValues { | |
hiveApiKey?: string | ||
labelerDid: string | ||
labelerKeywords: Record<string, string> | ||
unacceptableHandleWordsB64?: string | ||
falsePositiveHandleWordsB64?: string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nitpick: Loading this file would be better for transparency. Keep the env var though, the file should be a fallback used in prod! |
||
|
||
feedGenDid?: string | ||
|
||
|
@@ -163,6 +165,13 @@ export class ServerConfig { | |
const labelerDid = process.env.LABELER_DID || 'did:example:labeler' | ||
const labelerKeywords = {} | ||
|
||
const unacceptableHandleWordsB64 = nonemptyString( | ||
process.env.UNACCEPTABLE_HANDLE_WORDS_B64, | ||
) | ||
const falsePositiveHandleWordsB64 = nonemptyString( | ||
process.env.FALSE_POSITIVE_HANDLE_WORDS_B64, | ||
) | ||
|
||
const feedGenDid = process.env.FEED_GEN_DID | ||
|
||
const dbPostgresUrl = process.env.DB_POSTGRES_URL | ||
|
@@ -234,6 +243,8 @@ export class ServerConfig { | |
hiveApiKey, | ||
labelerDid, | ||
labelerKeywords, | ||
unacceptableHandleWordsB64, | ||
falsePositiveHandleWordsB64, | ||
feedGenDid, | ||
maxSubscriptionBuffer, | ||
repoBackfillLimitMs, | ||
|
@@ -425,6 +436,14 @@ export class ServerConfig { | |
return this.cfg.labelerKeywords | ||
} | ||
|
||
get unacceptableHandleWordsB64() { | ||
return this.cfg.unacceptableHandleWordsB64 | ||
} | ||
|
||
get falsePositiveHandleWordsB64() { | ||
return this.cfg.falsePositiveHandleWordsB64 | ||
} | ||
|
||
get feedGenDid() { | ||
return this.cfg.feedGenDid | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Loading this file would be better for transparency. Keep the env var though, the file should be a fallback used in prod!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think it'll be great if we know what are the words that are considered as unacceptable words here for transparency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just for transparency sake, but for future instances as well. A list contained solely in an env var means no other created instances get access