Push labels to PDS #1423
Merged
Push labels to PDS #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Aug 2, 2023
| "com.atproto.repo.strongRef" | ||
| ] | ||
| }, | ||
| "createLabelVals": { |
There was a problem hiding this comment.
i kinda want this to just take already formatted labels 🤔
so all the pds has to do is dumb shuffling of them off to the database, no formatting or anything & nowhere that the labels could get out of sync
There was a problem hiding this comment.
Yeah, I like that more—on it 👍
dholms
reviewed
Aug 2, 2023
| }, | ||
| }) | ||
|
|
||
| const res = await retryHttp(() => |
There was a problem hiding this comment.
this does max of 3 right? seems good 👍
dholms
approved these changes
Aug 2, 2023
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* add lexicon for unspecced applyLabels procedure * implement label push to pds via unspecced.applyLabels * add hive retry to bsky appview * build * update applyLabels to work with raw label data * update bsky hive labeler * remove build
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* add lexicon for unspecced applyLabels procedure * implement label push to pds via unspecced.applyLabels * add hive retry to bsky appview * build * update applyLabels to work with raw label data * update bsky hive labeler * remove build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the appview to push labels to the PDS using an unspecced route, as a temporary measure. Also adds an http retry to the hive labeler.