Include limited viewer info on blocked post #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 muchos gracias this is perf
I'm not overly bothered by this, but one thing we could consider doing is We know the did already from the URL so it doesn't violate anything, and it resolves this awkwardness. |
|
yeah I like that 👍 |
|
do you intend to make author optional? (we can get away with a breaking change here, I think). Otherwise +1 |
|
good call - I think we want author to be required but viewer to be optional |
|
Thanks! |
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
* include limited viewer info on block * blockedAuthor schema * make author required * merge & update codegen * patch up tests
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* include limited viewer info on block * blockedAuthor schema * make author required * merge & update codegen * patch up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes limited viewer info (blocking & blockedBy) on blocked posts. This helps the UI display the correct prompt.
One little point of friction: the
viewerhere is different from thevieweron post (post v actor). Do we want to adjust the property name at all?viewerActorfeels kinda sloppy