Add custom label definitions and tune various behaviors #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
commented
Feb 28, 2024
| @@ -64,29 +46,22 @@ | |||
| }, | |||
| "modServicePolicies": { | |||
| "type": "object", | |||
| "required": ["reportReasons", "labelValues"], | |||
There was a problem hiding this comment.
I'm dropping the custom report reasons for now, we'll FF with it but I think we gotta eject for now
dholms
reviewed
Mar 1, 2024
| "type": "array", | ||
| "description": "The label values which this labeler publishes. Be sure to prefix custom labels with 'x-'.", |
There was a problem hiding this comment.
just to check - we're doing away with both descriptions?
* codegen * clean up impl * fix up tests
pfrazee
force-pushed
the
3p-labelers-lexicon-updates
branch
from
d41cda1 to
343927e
Compare
…abel precedence rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
3p-labelerswith custom label definitions and some simplifications to labeler declarations and label management. This PR leaves multiple TODOs but it's at a good stopping-point to review the approach being taken.com.atproto.label.defs#labelValueDefinitionlabelerDid?: stringto the label preferencedetailedflag (still needs backend implementation)