Ozone lexicons #2288
Merged
Ozone lexicons #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
added a commit
to bluesky-social/indigo
that referenced
this pull request
Mar 12, 2024
…deprecated (#617) DO NOT MERGE YET This is based off the atproto PR: bluesky-social/atproto#2288 Does mostly expected things, adding `api/ozone` for tools.ozone.* namespace. Easier than expected because no records in that namespace, so no cborgen needed. There are some cborgen changes rolled up in this PR. I think I didn't commit changes to at least the bsky codegen, something about string and pointer-to-string. I assume those are unrelated to the namespace stuff and should be resolved in a separate clean PR. ~I haven't self-reviewed or tested this at all, should do that before merging or deploying. I *think* I caught all the string constants with `com.atproto.admin.defs#whatever` in code, but there might be more lurking (these don't result in compile-time errors).~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
com.atproto.adminOzone routes to newtools.ozonenamespace.Many
com.atproto.adminroutes are generic protocol routes, but the routes that are only important to Ozone's moderation capabilities have been pulled out into their own namespace.Note: this must be pared with a database migration to update existing schemas refs