Use blocked and not-found unions in post reply refs #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feed item views served from the appview include a
postand areplyfield. Thereplyfield contains views for the post's reply root and reply parent. Historically if the reply root/parent were missing or were blocked posts, we would simply omit thereplyfield entirely. With this change we will start to include it, and use theapp.bsky.feed.defs#notFoundPostorapp.bsky.feed.defs#blockedPostif the root/parent are missing or blocked respectively. This aligns the implementation with how the feed view lexicons were intended to be used.