Configure labeler service account in dev-env #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foysalit
commented
Mar 23, 2024
| @@ -73,7 +82,7 @@ export class TestNetwork extends TestNetworkNoAppView { | |||
| plcUrl: plc.url, | |||
| signingKey: ozoneKey, | |||
| serverDid: ozoneDid, | |||
| dbPostgresSchema: `ozone_${dbPostgresSchema}`, | |||
| dbPostgresSchema: `ozone_${dbPostgresSchema || 'db'}`, | |||
There was a problem hiding this comment.
unrelated change but this prevents the local db from being named ozone_undefined
foysalit
commented
Mar 23, 2024
|
|
||
| async createServiceDetails(pds: TestPds, ozoneUrl: string) { | ||
| const pdsClient = pds.getClient() | ||
| const describeRes = await pdsClient.api.com.atproto.server.describeServer() |
There was a problem hiding this comment.
This mostly mimics the way migration is done in account-migrations.test.ts
…-for-ozone-labeler
…-for-ozone-labeler
…-for-ozone-labeler
…-for-ozone-labeler
…-for-ozone-labeler
…-for-ozone-labeler
devinivy
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-wires the dev-env setup a little bit to create labeler service account which makes it easier to develop and plug ozone client locally into the dev-env.
The implementation is a bit "hacky" so want to lay out the flow and the reasoning.
The previous implementation created a DID for ozone without actually creating an account on any pds so with that DID, we couldn't create a labeler service record. However, the DID is needed when instantiating the appview and the pds so it's not as straight forward as starting the pds first and creating the labeler account.
So, this PR instantiates a temporary pds, creates an account and uses the DID for instantiating all the services (appview, pds and ozone) then migrates the account from temporary pds to the dev-env pds and shuts down the temporary pds. After migration, the labeler service record is created too.