lexicons: remove deprecated endpoints and fields #2376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Apr 4, 2024
| @@ -8,10 +8,6 @@ | |||
| "parameters": { | |||
| "type": "params", | |||
| "properties": { | |||
| "term": { | |||
There was a problem hiding this comment.
looks like these never got switched over in the client 🙃
There was a problem hiding this comment.
oh daaaarn. means we can't roll this out very confidently (don't want to break older clients).
I think the next step is probably to do a little PR that updates all that client API usage, and update this PR to not remove the deprecated term quite yet (maybe in a couple months).
This was referenced May 21, 2024
|
I broke this out in to 3x separate smaller PRs (see the "referenced" in github history above), so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't remove all
DEPRECATEDfields: some (like in repo event stream commit messages) are "required" and could be hard to deploy without disruption.These endpoints and fields are currently used at all and should not be disruptive to deploy. The most risky might be 'term' on the search endpoints.