Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add describeServer lexicon for ozone #2450

Closed
wants to merge 1 commit into from
Closed

Conversation

foysalit
Copy link
Contributor

This PR introduces a new tools.ozone.server.describeServer route to fetch info about ozone instance. As of now, it exposes the moderators with their role/access level.

@bnewbold
Copy link
Collaborator

Just to clarify, we won't make the set of moderators public and enumerable. If we do have an endpoint to enumerate them, requiring auth, it should have a different name to avoid confusion with com.atproto.server.describeServer, which is public.

@foysalit
Copy link
Contributor Author

yep, this enpoint is authed so not exposing anything publicly.
makes sense to change it from describeServer but I was hoping this will be a generic endpoint that will fetch all the server level config and not just the moderator list so it kinda made sense from that angle.
until we have proper user management, a dedicated endpoint just for exposing the moderator list feels a bit "extra" especially because the current list is configured through env var.

@devinivy
Copy link
Collaborator

devinivy commented May 8, 2024

I think the user only needs to know their own access level, so perhaps the full list could just be boiled down to the requesting user's access level.

@foysalit
Copy link
Contributor Author

Closing this in favor of #2460 which handles moderator ACL management and will create a separate PR for exposing server configs only.

@foysalit foysalit closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants