🚧 XRPC rework : class diagram simplification #2481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
xrpc-blob-upload
branch
from
fb5f17c to
3d83f50
Compare
matthieusieben
force-pushed
the
xrpc-fetch-handler
branch
3 times, most recently
from
de56ae1 to
36b81d5
Compare
fix(xrpc-server): allow upload of empty files
matthieusieben
force-pushed
the
xrpc-blob-upload
branch
from
3d83f50 to
8cbf61e
Compare
matthieusieben
force-pushed
the
xrpc-fetch-handler
branch
from
36b81d5 to
b0196fd
Compare
matthieusieben
force-pushed
the
xrpc-blob-upload
branch
3 times, most recently
from
60f4020 to
69632ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the concerns raised by @pfrazee in #2434, this PR simplifies the class diagram by replacing the
XrpcDispatcherby aFetchHandler. Here is what the class diagram looks like with these changes: