Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexicon: misc fixes to chat lexicons #2499

Merged
merged 4 commits into from
May 20, 2024
Merged

Lexicon: misc fixes to chat lexicons #2499

merged 4 commits into from
May 20, 2024

Conversation

devinivy
Copy link
Collaborator

@devinivy devinivy commented May 17, 2024 •
edited
Loading

A few small chat.bsky lexicon tweaks in here:

  • Add temporarily optional convoId to getMessageContext. Looking to be consistent about always qualifying messageId within a given convoId.
  • Rename #message to #messageInput and remove its optional id field.
  • Add a limit to the number of messages in sendMessageBatch.
  • Add required convoId to #messageRef used by ozone, make requisite ozone changes.

dholms
dholms approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🙌

@devinivy devinivy merged commit 06d2328 into main May 20, 2024
10 checks passed
@devinivy devinivy deleted the divy/lex-chat-misc-fixes branch May 20, 2024 14:13
@github-actions github-actions bot mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholms dholms dholms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinivy @dholms