Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Proposal for ozone config lexicons #2560

Closed
wants to merge 3 commits into from
Closed

🚧 Proposal for ozone config lexicons #2560

wants to merge 3 commits into from

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Jun 7, 2024

This proposal introduces a new entity config which is essentially a list of key value pairs where each key may have one or many values.

A few open questions

  1. Updates are tricky. The current proposal does not include updating a key or update values by wildcard.
  2. Create and update allows array input but delete only allows key and wildcard value input, do we want array input for deletion too?

One of the primary reasons why I'm in favor of calling this config and generalizing this is to facilitate storing shareable config for entire instance, that are currently browser based and as a result, user specific or stored in env var. For instance, our queue config is only stored in the env var of the client build and we could move that to the db under configs where each row with key queue would be the config for an individual queue. We also have external labeler config currently in review but ideally, we would want to store these on the server so that all mods using the instance see labels from same external labelers.

@foysalit foysalit requested a review from bnewbold June 7, 2024 09:09
@foysalit
Copy link
Contributor Author

We're moving forward with sets api instead of config #2636

@foysalit foysalit closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants