✨ Proxy starterpack requests through ozone and include takedowns #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jun 24, 2024
packages/dev-env/src/seed/basic.ts
Outdated
Comment on lines
158
to
159
| await sc.network.processAll() | ||
|
|
There was a problem hiding this comment.
All the other seeds let the caller perform the final processAll()— does it cause any issues if we stick with that for now?
There was a problem hiding this comment.
I see in the new test suite it works the same way:
await basicSeed(sc)
await network.processAll()There was a problem hiding this comment.
nope, don't think there's any issue with that. just cleaned up!
devinivy
added a commit
that referenced
this pull request
Jun 25, 2024
* lexicon: initial starter pack record lexicons * lexicon: first pass on views for starter packs * lexicon: add starter pack query endpoints, misc fixes * lexicon: add starter pack related fields to profile views * lexicon: codegen * api prerelease * bsky: protos for starter packs * appview: implement starter pack endpoints in dataplane, protos update * appview: starter pack hydration and view, mock dataplane indexing * appview: wire-up starter pack graph endpoints * appview: test basic starter packs functionality, update dev-env * fix snaps for profile createdAt * appview: fix list item count for starter packs in dataplane * fix ozone snaps, tidy * appview: reorg list aggs for starter packs * appview: starter pack lexicon and proto tweaks, move around aggregations * appview: fix views and snaps * api prerelease * fix snaps * appview: misc proto updates for starter packs, snaps * appview: add starter pack counts to profile detail * build * api prerelease * pds: starter pack slur detection * lexicon: starter pack notifications and batch fetch * appview: starter pack notification and batch fetch * appview: add starterpack-joined notif to dataplane and test * api prerelease * ozone: fix snaps * pds build * ✨ Proxy starterpack requests through ozone and include takedowns (#2594) * ✨ Proxy starterpack requests through ozone and include takedowns * 🧹 Cleanup * ✅ Commit snapshots * ✅ Update snapshot * lexicon: move starterpacks back to TIDs * changeset --------- Co-authored-by: Foysal Ahamed <foysal@blueskyweb.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.