Instantiate XrpcClient from an OAuthAgent

[matthieusieben]

• @atproto/api's Agent class can now be instantiated using a SessionManager interface (new Agent(sessMgr))
• @atproto/client's OAuthSession implements the SessionManager interface meaning that we can do new Agent(oauthSession)
• @atproto/api's AtpAgent works exactly as before. A comment was added to say that is will soon become deprecated as it adds no value anymore.
• @atproto/api now exposes an CredentialSession class that can be used to instantiate both new Agent(credSession) as-well-as new XrpcClient(credSession, myLex)

Potentially breaking changes:

• Agent is no longer abstract, and its constructor signature has changed. This means that any implementation extending that class will be broken. Since this abstract class was release very recently, the impact should be minimal.

• Agent no longer extends AtpBaseClient (this is an implementation detail so should no really impact anything)

• @atproto/oauth-client* no longer expose an agent, but a session instead. Adapting to this is very straight forward (new Agent(session)).

• OAuthAgent was renamed into OAuthSession and some method signatures where changed

[devinivy]

Looks good! I support this change to the oauth client 👍 I think it will be much friendlier to folks building their own apps, and at little cost of convenience.

It does stand out to me that the dependency of @atproto/oauth-client on @atproto/api is now very shallow. I can't help but wonder if there's a way to maintain the convenience of obtaining an OAuthAtpClient without the hard dependency on @atproto/api.

[matthieusieben]

Hey @devinivy, thank you for the review. I moved the OAuthAtpAgent class into the api agent. This reverses the dependency between @atproto/api and @atproto/oauth-client but that extra dependency in api is only needed for typing purposes and should not impact the bundle size.

With this change, the @atproto/api is no longer needed in order to instantiate custom @atproto/xrpc clients.

[matthieusieben]

This whole PR introduces a breaking change in the oauth-client* packages but I think it's fine since those were not released yet (will impact ozone but no big deal).

cc @foysalit

[matthieusieben]

Thanks @surfdude29 for your careful review <3

[surfdude29]

Thanks @surfdude29 for your careful review <3

No worries, happy to help :)

[devinivy]

A couple tiny questions but this looks good— very excited by these changes. Breaking the dependency between @atproto/api and @atproto/oauth-client is also 💎.

[pfrazee]

Interesting! I just noticed this part of the api for the first time.

Small thing: I wonder if this should be assertDid instead of accountDid to make this clearer?

[matthieusieben]

yep that would probably have been a better name -_-

[devinivy]

I'd recommend we add assertDid and deprecate accountDid at some point soon.

[matthieusieben]

bbca17b

[pfrazee]

Really great. I'm excited to be making progress on cleaning up all these interfaces -- they've been clunky for a long time before oauth.