OAuth: Add authorization scopes & remove OpenID compatibility #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
from
55befa7 to
8ff8e68
Compare
matthieusieben
changed the base branch from
main
to
msieben/oauth-atproto-scope
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
from
e004685 to
4472c23
Compare
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
from
4472c23 to
b26d33c
Compare
matthieusieben
force-pushed
the
msieben/oauth-atproto-scope
branch
from
c3abe00 to
30e319a
Compare
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
from
b26d33c to
325ac80
Compare
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
2 times, most recently
from
71405fc to
9aae108
Compare
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
2 times, most recently
from
5050389 to
f8a820a
Compare
…en building the authorization request.
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
2 times, most recently
from
4c85f4a to
1f03d97
Compare
devinivy
reviewed
Aug 24, 2024
devinivy
reviewed
Aug 24, 2024
devinivy
reviewed
Aug 24, 2024
matthieusieben
changed the base branch from
msieben/oauth-atproto-scope
to
main
matthieusieben
force-pushed
the
msieben/oauth-scopes
branch
from
0bd7014 to
ffcbaf6
Compare
|
@matthieusieben @devinivy I understand that this scoping feature needs to break openID compatibility through discussions, |
matthieusieben
changed the title
devinivy
reviewed
Aug 27, 2024
.changeset/six-swans-talk.md
Outdated
Comment on lines
1
to
5
| --- | ||
| "@atproto/pds": patch | ||
| --- | ||
|
|
||
| Disable ability to list app passwords when using an app password |
There was a problem hiding this comment.
I believe this change was reverted.
devinivy
approved these changes
Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for scopes during the authorization flow. Three scopes are introduced
atproto: acts as a negotiation scope between the client and the server so that both know that this is an ATProto OAuth flowtransition:generic: This temporary scope allows to give access tokens issued through OAuth the same permissions as current "app passwords".transition:chat.bsky: Grants access to chat functionalities, as was the case for "privileged app passwords"This change also removes the compatibility with OpenID.
The reason is that although the implementation was technically OpenID compatible, ATProto identifiers are distributed identifiers. When a client relies on OpenID to authenticate users, it will use the auth provider (issuer) in combination with the identifier to uniquely identify the user. Since ATProto identifiers are meant to be able to move from one provider to the other, OpenID compatibility could break authentication after a user was migrated to a different provider. Future authentication attempts would be considered as distinct identities from the one previsouly used by the client.
The way OpenID compliant clients would adapt to this particularity would typically be to remove the issuer + identifier combination and use the identifier alone. While this is indeed the right way to handle ATProto identifiers, it requires more work to avoid impersonation. In particular, when obtaining a user identifier, the client must verify that the issuer of the identity token is indeed the server responsible for that user. This mechanism being not enforced by the OpenID standard, OpenID compatibility could lead to security issues. For this reason, we decided to remove OpenID compatibility from the OAuth provider.
Note that a trusted central authority could still offer OpenID compatibility by relying on ATProto's regular OAuth flow under the hood. This capability is out of the scope of this library.