OAuth: Enable to configure scope via query parameter for loopback client metadata #2753
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey ! Thank you for you suggestion. This issue was actually reported to us yesterday and I already started integrating that fix in another branch. Since both are changes redundant, and because this branch did not account for "multiple allowed" part of the spec, I'll go ahead and close this PR in favor of the other one. Feel free to comment / open another issue. |
Vincentroland
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The draft OAuth Spec says that for localhost clients, the
scope"can be configured via query parameter in theclient_idURL", and "Default isatproto”, but this was not the case.https://github.com/bluesky-social/atproto-website/blob/bnewbold/spec-oauth/content/specs/auth.md#localhost-client-development
So I implemented it to work as per the spec.