Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong imports in oauth-client-node README #2844

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

KevSlashNull
Copy link
Contributor

In the @atproto/oauth-client-node README code examples, this:

  1. adds missing imports,
  2. fixes the NodeOAuthClient import (because NodeOAuthClientOptions is just a type, not a constructor),
  3. and adds async to some functions in the options, so they actually return Promises.

Copy link
Contributor

@matthieusieben matthieusieben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dholms
Copy link
Collaborator

dholms commented Oct 1, 2024

Not exactly sure what the linting error here is, but do you mind running a quick pnpm format @KevSlashNull?

@surfdude29
Copy link
Contributor

Sorry for jumping in here, I think the linting error might have been in a different README and was fixed in 3c7bf81 ?

@KevSlashNull
Copy link
Contributor Author

@dholms, I think @surfdude29 is right, so I rebased.

@devinivy devinivy merged commit 4e09849 into bluesky-social:main Oct 4, 2024
10 checks passed
@KevSlashNull KevSlashNull deleted the patch-1 branch October 4, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants