Various OAuth related fixes #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2816 |
devinivy
reviewed
Oct 10, 2024
devinivy
reviewed
Oct 10, 2024
devinivy
reviewed
Oct 10, 2024
Comment on lines
+131
to
+132
| // Optimized version of: | ||
| // return input.split(' ').includes(value) |
There was a problem hiding this comment.
Seems pretty nice! Is there an issue with using this implementation?
There was a problem hiding this comment.
The split() implementation is about 10 times slower (in firefox). I'm just tying to save the planet here, one CPU cycle at the time 😅.
devinivy
reviewed
Oct 10, 2024
Co-authored-by: devin ivy <devinivy@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.