Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root block missing in too big seq commit #2894

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Fix root block missing in too big seq commit #2894

merged 3 commits into from
Oct 29, 2024

Conversation

MarshalX
Copy link
Contributor

fixes #2893

dholms
dholms approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the test.

Made a small tweak, and will get this merged after CI passes

@dholms dholms mentioned this pull request Oct 29, 2024
Closed
@dholms dholms merged commit de19439 into bluesky-social:main Oct 29, 2024
10 checks passed
@MarshalX MarshalX deleted the fix-missed-root-block-in-too-big-seq-commit branch October 29, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholms dholms dholms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firehose consumers do not receive root block in case of too big seq commit
2 participants
@MarshalX @dholms