Add threat signatures to admin view #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Oct 30, 2024
| "type": "object", | ||
| "required": ["property", "value"], | ||
| "properties": { | ||
| "property": { "type": "string" }, |
There was a problem hiding this comment.
The way I think of it, the threat signature has multiple properties, each of which has a name and a value. So I think of this as a name. But it's truly a bikeshed, all good either way.
There was a problem hiding this comment.
yeah I see where you're coming from, but we already have stuff in entryway codebase around this naming convention and this isn't so far off that I wanna do DB migrations for it 😅
devinivy
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively freeform field for attaching additional arbitrary threat signatures to a given admin view