Reset password during OAuth flow #2945
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msi/oauth-reset-pwd
branch
from
c0c3a55 to
64357d1
Compare
matthieusieben
changed the base branch from
main
to
msi/refactor-actor-store-reader
matthieusieben
force-pushed
the
msi/oauth-reset-pwd
branch
from
64357d1 to
bcc7f5d
Compare
matthieusieben
force-pushed
the
msi/refactor-actor-store-reader
branch
from
01c11c6 to
0dbb458
Compare
matthieusieben
force-pushed
the
msi/oauth-reset-pwd
branch
5 times, most recently
from
bb81208 to
3f768b2
Compare
matthieusieben
force-pushed
the
msi/oauth-reset-pwd
branch
17 times, most recently
from
e22b78d to
9a40a57
Compare
matthieusieben
force-pushed
the
msi/oauth-reset-pwd
branch
from
9a40a57 to
d1e3858
Compare
matthieusieben
force-pushed
the
msi/oauth-reset-pwd
branch
5 times, most recently
from
acd3770 to
a3693e0
Compare
matthieusieben
force-pushed
the
msi/oauth-reset-pwd
branch
from
9dd2837 to
87fba04
Compare
matthieusieben
commented
Feb 28, 2025
| @@ -502,250 +548,4 @@ export class AccountManager | |||
| ]), | |||
| ) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Most of this code didn't change and was just moved in ./oauth-store.
matthieusieben
commented
Feb 28, 2025
| * | ||
| * @note The use of this class assumes that there is no entryway. | ||
| */ | ||
| export class OAuthStore |
There was a problem hiding this comment.
Most of this code was just moved from ./account-manager. What changes is only the stuff related to the AccountStore:
- account creation
- binding of device-account
- reset password
- handle availability
See the diff of the AccountStore interface to be able to tell which method have changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.