Fix optimistic getPostThread for URIs with handle #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
resolve-handles-postthread-raw
branch
from
7f25a8b to
cb3e296
Compare
gaearon
commented
Nov 4, 2024
| if (account) { | ||
| uri.hostname = account.did | ||
| } | ||
| } | ||
| if (uri.hostname !== requester) throw err |
There was a problem hiding this comment.
this check would previously lead to 404
dholms
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
getPostThreadread-after-write handling was not takingat://<handle>/...URIs into account. This resulted in the PDS returning 404 for post thread query whenever relay is lagging, which resulted in a confusing UX in the app (the post would show up but clicking into it would show 404). This should fix that.Test Plan
See two additions to tests. One of those worked before, the other one failed. Now both work.