Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better service landing pages #2959

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

bnewbold
Copy link
Collaborator

@bnewbold bnewbold commented Nov 8, 2024

No description provided.

@bnewbold bnewbold requested review from devinivy and dholms November 8, 2024 01:06
@mary-ext
Copy link
Contributor

mary-ext commented Nov 8, 2024

the PDS' ASCII art doesn't seem very readable 😅

@bnewbold bnewbold force-pushed the bnewbold/better-pds-landing branch from d762dd3 to 8668372 Compare November 8, 2024 03:19
@bnewbold
Copy link
Collaborator Author

bnewbold commented Nov 8, 2024

(accidentally had this on top of an unrelated branch, did a force-push to fix that)

@mary-ext do you mean in the response, or in the source code? TS requires backslash-escaping for backslashes, so it looks wrong in the source code, but should display Ok in the actual HTTP response.

@mary-ext
Copy link
Contributor

mary-ext commented Nov 8, 2024

Ah, realized there were escapes. It definitely seems better

Copy link
Contributor

@tesaguri tesaguri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few additional HTML markups help to improve accessibility when accessed using Web browsers.

Comment on lines 8 to +24
res.type('text/plain')
res.send(
'This is an AT Protocol Application View (AppView) for the "bsky.app" application: https://github.com/bluesky-social/atproto\n\nMost API routes are under /xrpc/',
)
res.send(`
_ _
| | | |
| |__ ___| | ___ _
| '_ \\/ __| |/ / | | |
| |_) \\__ \\ <| |_| |
|_.__/|___/_|\\_\\\\__, |
__/ |
|___/

This is an AT Protocol Application View (AppView) for the "bsky.app" application.

Most API routes are under /xrpc/

Code: https://github.com/bluesky-social/atproto
Protocol: https://atproto.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res.type('text/plain')
res.send(
'This is an AT Protocol Application View (AppView) for the "bsky.app" application: https://github.com/bluesky-social/atproto\n\nMost API routes are under /xrpc/',
)
res.send(`
_ _
| | | |
| |__ ___| | ___ _
| '_ \\/ __| |/ / | | |
| |_) \\__ \\ <| |_| |
|_.__/|___/_|\\_\\\\__, |
__/ |
|___/
This is an AT Protocol Application View (AppView) for the "bsky.app" application.
Most API routes are under /xrpc/
Code: https://github.com/bluesky-social/atproto
Protocol: https://atproto.com
res.type('text/html')
res.send(`
<div role="heading" aria-level="1"><pre role="img" aria-label="bsky">
_ _
| | | |
| |__ ___| | ___ _
| '_ \\/ __| |/ / | | |
| |_) \\__ \\ <| |_| |
|_.__/|___/_|\\_\\\\__, |
__/ |
|___/
</pre></div>
<p>This is an AT Protocol Application View (AppView) for the "bsky.app" application.</p>
<p>Most API routes are under <code>/xrpc/</code></p>
<ul>
<li><a href="https://github.com/bluesky-social/atproto">Code</a></li>
<li><a href="https://atproto.com">Protocol</a></li>
</ul>

Comment on lines +9 to +29
res.type('text/plain')
res.send(`
,o888888o. 8888888888',8888' ,o888888o. b. 8 8 8888888888
. 8888 '88. ,8',8888'. 8888 '88. 888o. 8 8 8888
,8 8888 '8b ,8',8888',8 8888 '8b Y88888o. 8 8 8888
88 8888 '8b ,8',8888' 88 8888 '8b .'Y888888o. 8 8 8888
88 8888 88 ,8',8888' 88 8888 88 8o. 'Y888888o. 8 8 888888888888
88 8888 88 ,8',8888' 88 8888 88 8'Y8o. 'Y88888o8 8 8888
88 8888 ,8P ,8',8888' 88 8888 ,8P 8 'Y8o. 'Y8888 8 8888
'8 8888 ,8P ,8',8888' '8 8888 ,8P 8 'Y8o. 'Y8 8 8888
' 8888 ,88' ,8',8888' ' 8888 ,88' 8 'Y8o.' 8 8888
'8888888P' ,8',8888888888888 '8888888P' 8 'Yo 8 888888888888


This is an AT Protocol Moderation Service API Server.

Most API routes are under /xrpc/

Code: https://github.com/bluesky-social/atproto
Self-Host: https://github.com/bluesky-social/ozone
Protocol: https://atproto.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res.type('text/plain')
res.send(`
,o888888o. 8888888888',8888' ,o888888o. b. 8 8 8888888888
. 8888 '88. ,8',8888'. 8888 '88. 888o. 8 8 8888
,8 8888 '8b ,8',8888',8 8888 '8b Y88888o. 8 8 8888
88 8888 '8b ,8',8888' 88 8888 '8b .'Y888888o. 8 8 8888
88 8888 88 ,8',8888' 88 8888 88 8o. 'Y888888o. 8 8 888888888888
88 8888 88 ,8',8888' 88 8888 88 8'Y8o. 'Y88888o8 8 8888
88 8888 ,8P ,8',8888' 88 8888 ,8P 8 'Y8o. 'Y8888 8 8888
'8 8888 ,8P ,8',8888' '8 8888 ,8P 8 'Y8o. 'Y8 8 8888
' 8888 ,88' ,8',8888' ' 8888 ,88' 8 'Y8o.' 8 8888
'8888888P' ,8',8888888888888 '8888888P' 8 'Yo 8 888888888888
This is an AT Protocol Moderation Service API Server.
Most API routes are under /xrpc/
Code: https://github.com/bluesky-social/atproto
Self-Host: https://github.com/bluesky-social/ozone
Protocol: https://atproto.com
res.type('text/html')
res.send(`
<div role="heading" aria-level="1"><pre role="img" aria-label="Ozone">
,o888888o. 8888888888',8888' ,o888888o. b. 8 8 8888888888
. 8888 '88. ,8',8888'. 8888 '88. 888o. 8 8 8888
,8 8888 '8b ,8',8888',8 8888 '8b Y88888o. 8 8 8888
88 8888 '8b ,8',8888' 88 8888 '8b .'Y888888o. 8 8 8888
88 8888 88 ,8',8888' 88 8888 88 8o. 'Y888888o. 8 8 888888888888
88 8888 88 ,8',8888' 88 8888 88 8'Y8o. 'Y88888o8 8 8888
88 8888 ,8P ,8',8888' 88 8888 ,8P 8 'Y8o. 'Y8888 8 8888
'8 8888 ,8P ,8',8888' '8 8888 ,8P 8 'Y8o. 'Y8 8 8888
' 8888 ,88' ,8',8888' ' 8888 ,88' 8 'Y8o.' 8 8888
'8888888P' ,8',8888888888888 '8888888P' 8 'Yo 8 888888888888
</pre></div>
<p>This is an AT Protocol Moderation Service API Server.</p>
<p>Most API routes are under <code>/xrpc/</code></p>
<ul>
<li><a href="https://github.com/bluesky-social/atproto">Code</a></li>
<li><a href="https://github.com/bluesky-social/ozone">Self-Host</a></li>
<li><a href="https://atproto.com">Protocol</a></li>
</ul>

Comment on lines 9 to +28
res.type('text/plain')
res.send(
'This is an AT Protocol Personal Data Server (PDS): https://github.com/bluesky-social/atproto\n\nMost API routes are under /xrpc/',
)
res.send(`
__ __
/\\ \\__ /\\ \\__
__ \\ \\ ,_\\ _____ _ __ ___\\ \\ ,_\\ ___
/'__'\\ \\ \\ \\/ /\\ '__'\\/\\''__\\/ __'\\ \\ \\/ / __'\\
/\\ \\L\\.\\_\\ \\ \\_\\ \\ \\L\\ \\ \\ \\//\\ \\L\\ \\ \\ \\_/\\ \\L\\ \\
\\ \\__/.\\_\\\\ \\__\\\\ \\ ,__/\\ \\_\\\\ \\____/\\ \\__\\ \\____/
\\/__/\\/_/ \\/__/ \\ \\ \\/ \\/_/ \\/___/ \\/__/\\/___/
\\ \\_\\
\\/_/


This is an AT Protocol Personal Data Server (aka, an atproto PDS)

Most API routes are under /xrpc/

Code: https://github.com/bluesky-social/atproto
Self-Host: https://github.com/bluesky-social/pds
Protocol: https://atproto.com
Copy link
Contributor

@tesaguri tesaguri Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res.type('text/plain')
res.send(
'This is an AT Protocol Personal Data Server (PDS): https://github.com/bluesky-social/atproto\n\nMost API routes are under /xrpc/',
)
res.send(`
__ __
/\\ \\__ /\\ \\__
__ \\ \\ ,_\\ _____ _ __ ___\\ \\ ,_\\ ___
/'__'\\ \\ \\ \\/ /\\ '__'\\/\\''__\\/ __'\\ \\ \\/ / __'\\
/\\ \\L\\.\\_\\ \\ \\_\\ \\ \\L\\ \\ \\ \\//\\ \\L\\ \\ \\ \\_/\\ \\L\\ \\
\\ \\__/.\\_\\\\ \\__\\\\ \\ ,__/\\ \\_\\\\ \\____/\\ \\__\\ \\____/
\\/__/\\/_/ \\/__/ \\ \\ \\/ \\/_/ \\/___/ \\/__/\\/___/
\\ \\_\\
\\/_/
This is an AT Protocol Personal Data Server (aka, an atproto PDS)
Most API routes are under /xrpc/
Code: https://github.com/bluesky-social/atproto
Self-Host: https://github.com/bluesky-social/pds
Protocol: https://atproto.com
res.type('text/html')
res.send(`
<div role="heading" aria-level="1"><pre role="img" aria-label="atproto">
__ __
/\\ \\__ /\\ \\__
__ \\ \\ ,_\\ _____ _ __ ___\\ \\ ,_\\ ___
/'__'\\ \\ \\ \\/ /\\ '__'\\/\\''__\\/ __'\\ \\ \\/ / __'\\
/\\ \\L\\.\\_\\ \\ \\_\\ \\ \\L\\ \\ \\ \\//\\ \\L\\ \\ \\ \\_/\\ \\L\\ \\
\\ \\__/.\\_\\\\ \\__\\\\ \\ ,__/\\ \\_\\\\ \\____/\\ \\__\\ \\____/
\\/__/\\/_/ \\/__/ \\ \\ \\/ \\/_/ \\/___/ \\/__/\\/___/
\\ \\_\\
\\/_/
</pre></div>
<p>This is an AT Protocol Personal Data Server (aka, an atproto PDS)</p>
<p>Most API routes are under <code>/xrpc/</code></p>
<ul>
<li><a href="https://github.com/bluesky-social/atproto">Code</a></li>
<li><a href="https://github.com/bluesky-social/pds">Self-Host</a></li>
<li><a href="https://atproto.com/">Protocol</a></li>
</ul>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants