Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searchStarterPacks to appview #2978

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Add searchStarterPacks to appview #2978

merged 8 commits into from
Nov 18, 2024

Conversation

rafaelbsky
Copy link
Contributor

@rafaelbsky rafaelbsky commented Nov 11, 2024

This adds:

  1. The lexicon app.bsky.graph.searchStarterPacks and its implementation in the bsky package.
  2. The lexicon app.bsky.unspecced.searchStarterPacksSkeleton, to be implemented by the search service.

@rafaelbsky rafaelbsky force-pushed the starter-pack-search branch 2 times, most recently from ec2861c to d522841 Compare November 12, 2024 15:10
@rafaelbsky rafaelbsky marked this pull request as ready for review November 13, 2024 02:59
@rafaelbsky rafaelbsky marked this pull request as draft November 14, 2024 02:03
@rafaelbsky rafaelbsky marked this pull request as ready for review November 14, 2024 02:08
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! The only thing we might want to consider here is indexing the starter pack names so that some form of search is implemented in the dataplane.

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. let's add a changeset for the @atproto/api package to this PR, so that a version of that package containing the new search lexicon can be published.

@rafaelbsky rafaelbsky merged commit a4b528e into main Nov 18, 2024
10 checks passed
@rafaelbsky rafaelbsky deleted the starter-pack-search branch November 18, 2024 13:36
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants