Filtering on listNotifications #3225
Merged
+389
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
rafaelbsky
approved these changes
Dec 11, 2024
dholms
commented
Dec 11, 2024
| @@ -417,6 +417,84 @@ describe('notification views', () => { | |||
| ), | |||
| ).toBe(true) | |||
| expect(forSnapshot(notifs.data)).toMatchSnapshot() | |||
| await agent.api.app.bsky.notification.putPreferences( | |||
There was a problem hiding this comment.
this was really weird - i was getting intermittent failures (maybe 1/3 of the time) where updating carol's priority setting would also set alice's to true. I tried for awhile to debug this, but couldn't find the source of it. Verified only one call to mock bsync & that's the only place that I could find where this is updated.
I ended up just adding this call to revert carol's priority setting after the test which is just kinda nice tidiness in the test suite anyway but unblocked this flaky test.
If anyone has ideas on what could be happening plz drop them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for: #3222
Filter notifications by provided
reason. Since this will often dramatically reduce the result set, we also add in some logic for paginating on the server side. Right now, we paginate until one of 3 conditions are met:limitWe can adjust the first to numbers if we find the current configuration isn't working as we like