Did caching #856
Merged
Did caching #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Apr 23, 2023
| .executeTakeFirst() | ||
| if (!res) return null | ||
| const now = Date.now() | ||
| const updatedAt = new Date(res.updatedAt).getTime() |
There was a problem hiding this comment.
Date may not have to come into play here since res.updatedAt is a unix timestamp itself.
There was a problem hiding this comment.
oh yeah i had that as Date originally 🙃
devinivy
reviewed
Apr 23, 2023
|
|
||
| export interface DidCache { | ||
| did: string | ||
| doc: DidDocument |
There was a problem hiding this comment.
Is it all good for tombstoned dids to be cached here?
There was a problem hiding this comment.
I cleaned it up a bit so if we try to refresh & it's missing, we'll clear out the cache. should fix tombstoned dids 👍
devinivy
approved these changes
Apr 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from simple-service-auth for ease of review
This adds a Postgres DID cache to the appview building off of #842
We do stale-while-revalidate when TTL is passed & can override the cache for sensitive operations such as updating indexed handles