Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript api package auth refactor blog post #171

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

bnewbold
Copy link
Contributor

@bnewbold bnewbold commented Aug 10, 2024

This was @matthieusieben's original write-up, with some edits.

Copy link

render bot commented Aug 10, 2024

@bnewbold bnewbold marked this pull request as ready for review August 10, 2024 01:08
@bnewbold bnewbold requested a review from devinivy August 10, 2024 01:08
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
Co-authored-by: Matthieu Sieben <matthieusieben@users.noreply.github.com>
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just proofread, didn't pay attention to any code. Reads well to me!

blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
blog/2024-08-12-ts-api-refactor.md Outdated Show resolved Hide resolved
Co-authored-by: Hailey <hailey@blueskyweb.xyz>
Copy link
Contributor

@matthieusieben matthieusieben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnewbold bnewbold merged commit 0335286 into main Aug 12, 2024
@bnewbold bnewbold deleted the bnewbold/sdk-auth-refactor branch August 12, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants