reduce hard-coding of entryway URL in docs #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding https://bsky.social in the guide, use a variable 'pds_url', which is what the cookbook code does.
Have `curl` examples use a $PDSHOST variable instead of hard-coding https://bsky.social in the examples. Use handle.example.com instead of example.com. Use updated/current invocation of python SDK, which doesn't require entryway URL.
arcalinea
temporarily deployed
to
bnewbold/reduce-entryway - bsky-docs PR #197
Render
Destroyed
ericvolp12
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to have folks connect to their actual PDS, instead of the entryway (
https://bsky.social).This is a small/focused PR just around hardcoded examples in the text of tutorials and guides. I'm also going to add a guide describing how to decide where to connect to, and make changes to the HTTP API reference docs.