Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Typescript" with "TypeScript", "Javascript" with "JavaScript" #223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jakebailey
Copy link

Sorry, this bugged me 😅

@jakebailey
Copy link
Author

Also Javascript -> JavaScript

@jakebailey
Copy link
Author

(Not 100% clear to me if some of this is generated code though)

@jakebailey jakebailey changed the title Replace "Typescript" with "TypeScript" Replace "Typescript" with "TypeScript", "Javascript" with "JavaScript" Nov 11, 2024
@mary-ext
Copy link
Contributor

mary-ext commented Nov 11, 2024

I think they are automatically generated since we don't natively consume the OpenAPI schemas on the protocol (they're only here because there's OpenAPI docgens and it doesn't seem worth to build one for lexicons)

Would recommend looking at the lexicons/ folder on the atproto repository

@jakebailey
Copy link
Author

I guess some are, some aren't, then. Fun 😄

@jakebailey
Copy link
Author

Hm, that repo contains no instances of Typescript, but does contains Javascript, so I guess the first commit of this PR is fine.

@BridgeAR
Copy link

While being on it, would you mind renaming Node.js related things (NodeJS, Node.JS, Nodejs, Node) as well? 😄

@jakebailey
Copy link
Author

I can, though I'm not sure if this repo is being watched for outside contributions so I'll defer that until later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants