Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch subscription endpoint #69

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

dolciss
Copy link
Contributor

@dolciss dolciss commented Nov 10, 2023

This PR is Change endpoint to BGS firehose on .env.example and index.ts
cf. bluesky-social/atproto#1711

@roqvist
Copy link

roqvist commented Nov 15, 2023

This is important for everyone who is not subscribing to the dev mailing list. A new timestamp in this repository alone would help highlight this breaking change.

@mackuba
Copy link
Contributor

mackuba commented Nov 16, 2023

+1

@mackuba
Copy link
Contributor

mackuba commented Nov 19, 2023

Ping @bnewbold @dholms

@tomh5905
Copy link

Shouldn't the default endpoint in index.ts be changed as well so that the repo works directly after cloning without having to make a .env file?

@dolciss
Copy link
Contributor Author

dolciss commented Nov 20, 2023

Shouldn't the default endpoint in index.ts be changed as well so that the repo works directly after cloning without having to make a .env file?

Yes, I noticed that when I saw your comment, and just made the additional commit, thanks!

@dholms
Copy link
Contributor

dholms commented Nov 21, 2023

Can't believe I missed this update - too many things happening! Thank you for putting this together 👍

@dholms dholms merged commit 1207363 into bluesky-social:main Nov 21, 2023
@dholms dholms mentioned this pull request Nov 21, 2023
@dolciss
Copy link
Contributor Author

dolciss commented Nov 22, 2023

Thanks!

@dolciss dolciss deleted the subscription-endpoint branch November 22, 2023 00:28
@dolciss dolciss restored the subscription-endpoint branch November 22, 2023 00:55
@dolciss dolciss deleted the subscription-endpoint branch November 22, 2023 00:56
vSLG pushed a commit to vSLG/marisa-feed-generator that referenced this pull request Feb 29, 2024
* Switch subscription endpoint

* Switch on fallback default value
haileyok pushed a commit that referenced this pull request Oct 31, 2024
* Switch subscription endpoint

* Switch on fallback default value
haileyok pushed a commit that referenced this pull request Oct 31, 2024
* Switch subscription endpoint

* Switch on fallback default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants