Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unpublishFeedGen script #77

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

dolciss
Copy link
Contributor

@dolciss dolciss commented Jan 7, 2024

This PR is based on a feature request from #76,
and I am modifying my own script to applying it in the main repository.


// YOUR bluesky password, or preferably an App Password (found in your client settings)
// Ex: abcd-1234-efgh-5678
const password = ''

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we read this from input prompt or .env? Seems safer than people potentially hardcoding password and pushing it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
Yes, I am aware of the possibility of hard coding and pushing too.
However, I am doing the same once the PR #50 for publishFeedGen has not been merged.
Once PR #50 is merged, we will fix this as well :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm super late to the party 😭

I added inquirer to get all of these values, since it is just too darn easy to make a commit right now with a credential and, frankly, its a bit easier to just run the script real quick and enter inputs then have to make changes to the file itself. If anyone wants to tweak it still though, feel free.

@ebwinters
Copy link

Hey just wondering, who reviews PRs in this repo? Have had one outstanding for a while and would like to get it merged or rejected

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@haileyok haileyok merged commit 437315b into bluesky-social:main Oct 31, 2024
@dolciss dolciss deleted the unpubish-feed branch November 18, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants