-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unpublishFeedGen script #77
Conversation
|
||
// YOUR bluesky password, or preferably an App Password (found in your client settings) | ||
// Ex: abcd-1234-efgh-5678 | ||
const password = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we read this from input prompt or .env? Seems safer than people potentially hardcoding password and pushing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm super late to the party 😭
I added inquirer to get all of these values, since it is just too darn easy to make a commit right now with a credential and, frankly, its a bit easier to just run the script real quick and enter inputs then have to make changes to the file itself. If anyone wants to tweak it still though, feel free.
Hey just wondering, who reviews PRs in this repo? Have had one outstanding for a while and would like to get it merged or rejected |
d36deef
to
fadd462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
This PR is based on a feature request from #76,
and I am modifying my own script to applying it in the main repository.