-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Palomar: Add alt text to ES Doc Text field #248
Palomar: Add alt text to ES Doc Text field #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh great idea, Thanks @jcsalterego !
I can't seem to reproduce the test failure locally. Is it a related failure? |
It passed in this CI build FWIW https://github.com/jcsalterego/indigo/actions/runs/5662477475/job/15342470966 |
Yeah, thats a known flaky test. I need to figure out how to deal with that better... |
rerunning the tests to try and get a clean merge |
I figure adding a sleep between would remove the timing/race condition but I couldn't tell you why :) |
Would love to know if there's anything I can do to help this get merged! |
I assume this is on hold for a larger mapping change and task to reindex all posts? |
I think this would be good to get merged and online, even if it's only for a portion of the data (no backfill), and pending some larger changes in the schema. |
This feature should be working in prod as of the past couple weeks, as part of a broader refactor of how we index posts. It took forever! I'm going to close this PR; if the feature isn't working the way you expect, please re-open an issue. Sorry to leave you hanging on this helpful PR for so long, and thanks again for the contribution. |
@bnewbold The big search refactor looks great and was worth the wait. Thanks! |
Adds alt text for images to the ES doc's text field.
For example:
Given
Then