Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palomar: 'OR' for single-token profile searches #663

Merged
merged 1 commit into from
May 3, 2024
Merged

palomar: 'OR' for single-token profile searches #663

merged 1 commit into from
May 3, 2024

Conversation

bnewbold
Copy link
Collaborator

@bnewbold bnewbold commented May 1, 2024

Just sketching, didn't even test this against a local index

@bnewbold bnewbold requested a review from ericvolp12 May 1, 2024 00:39
ericvolp12
ericvolp12 approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@ericvolp12 ericvolp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested the constructed query on the prod cluster and it looks like it works)

@bnewbold bnewbold merged commit ef8e99b into main May 3, 2024
7 checks passed
@bnewbold bnewbold deleted the bnewbold/palomar-profile-or branch May 3, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvolp12 ericvolp12 ericvolp12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnewbold @ericvolp12