beemo: refactor and add mention notifications #674
Conversation
|
@ericvolp12 nothing very high-stakes here but a skim and plus1 would be good if you get a sec |
| // NOTE: could add other callbacks as needed | ||
| } | ||
|
|
||
| var scheduler events.Scheduler |
There was a problem hiding this comment.
I would recommend using the parallelScheduler tbh, the autoscalingScheduler has been more trouble than it's worth lately.
| if mention == nil { | ||
| continue | ||
| } | ||
| for _, d := range mc.mentionDIDs { |
There was a problem hiding this comment.
Instead of a for loop over a list here, you could make mentionDIDs a map and key into it, would be a bit more idiomatic Go if that's the only way we're using that struct (to check membership), turn mentionDIDs into a map[string]struct{} which is Go's version of a "set"
There was a problem hiding this comment.
you are correct, but i'm going to be lazy and skip on this refactor in this case. i'll try to use that pattern more in the future
| // query just new reports (regardless of resolution state) | ||
| // ModerationQueryEvents(ctx context.Context, c *xrpc.Client, createdBy string, cursor string, includeAllUserRecords bool, limit int64, sortDirection string, subject string, types []string) (*ModerationQueryEvents_Output, error) | ||
| var limit int64 = 50 | ||
| me, err := toolsozone.ModerationQueryEvents( |
There was a problem hiding this comment.
lol lmao, love this method
There was a problem hiding this comment.
yeah, it's a bummer what is fairly reasonable/idiomatic for API design ends up so bad in codegen here. several ways we could re-architect the codegen some day. maybe worth creating a more ergonomic wrapper (with config struct) for a handful of these monster methods.
No description provided.