Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in postgres use optimized where in query #681

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

whyrusleeping
Copy link
Collaborator

We need to find a good way to run these tests on postgres

@whyrusleeping whyrusleeping requested a review from ericvolp12 June 5, 2024 17:53
@bnewbold
Copy link
Collaborator

re: postgresql testing

The atproto repo (typescript) has some helper scripts for setting up a local postgresql during test invocation. It slows things down a little bit, but in go we could tag the tests which need that, and run them as a separate make command (?), and have CI run that and the regular tests together; shouldn't be too bad.

@ericvolp12 ericvolp12 merged commit 092ea1c into main Aug 16, 2024
7 checks passed
@ericvolp12
Copy link
Collaborator

Merged this since commit c13ab32 is what's actually in prod rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants