fix nil pointer exception on creating account, when relay is self-hosted

[itaru2622]

close #704

[itaru2622]

this PR fix the em-bug by #696

[itaru2622]

@ericvolp12 @bnewbold could you review this PR please.

[bnewbold]

Looks like a good catch!

Instead of duplicating the nil check and assignment in both conditional branches of the if statement, could you move it just above? Like:

diff --git a/cmd/bigsky/main.go b/cmd/bigsky/main.go
index 33e60a0b..d0961ecc 100644
--- a/cmd/bigsky/main.go
+++ b/cmd/bigsky/main.go
@@ -348,10 +348,10 @@ func runBigsky(cctx *cli.Context) error {
 
        rlskip := cctx.String("bsky-social-rate-limit-skip")
        ix.ApplyPDSClientSettings = func(c *xrpc.Client) {
+               if c.Client == nil {
+                       c.Client = util.RobustHTTPClient()
+               }
                if strings.HasSuffix(c.Host, ".bsky.network") {
-                       if c.Client == nil {
-                               c.Client = util.RobustHTTPClient()
-                       }
                        c.Client.Timeout = time.Minute * 30
                        if rlskip != "" {
                                c.Headers = map[string]string{

[itaru2622]

@bnewbold thank you for your review. I followed your comment and pushed update.