Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IdenticalReplyPostSameParentRule to automod #746

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Sep 5, 2024

adds a spam label to accounts that are under 24 hours doing this, otherwise just reports. maybe too hasty on the label, can adjust. (note our client really doesn't make it easy to make an identical post multiple times in a row like this, where even failures will usually close the composer anyway, so its likely to be intentional). same could probably be applied for same author but with a maybe higher limit

@haileyok haileyok force-pushed the hailey/identical-reply-same-parent branch from 66de6c1 to e0a717d Compare September 5, 2024 05:01
Copy link
Collaborator

@bnewbold bnewbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This rocks and I think would be safe to merge+deploy as written.

Left some comments but overall good.

automod/rules/replies.go Show resolved Hide resolved
automod/rules/replies.go Outdated Show resolved Hide resolved
if count >= identicalReplySameParentLimit {
// if account is young, add spam label. otherwise just report.
createdAt := c.Account.CreatedAt
c.AddAccountFlag("multi-identical-reply-same-post")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had these all over the place earlier, I think we could just skip or remove adding these flags now? hrm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️ adds context to slack ig, lmk if should rm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right!

automod/rules/replies.go Outdated Show resolved Hide resolved
@bnewbold bnewbold merged commit 2462d58 into main Sep 5, 2024
7 checks passed
@bnewbold bnewbold deleted the hailey/identical-reply-same-parent branch September 5, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants