Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mst: clarify in comment that fields are nullable, not optional #766

Merged
merged 1 commit into from
Sep 27, 2024
Merged

mst: clarify in comment that fields are nullable, not optional #766

merged 1 commit into from
Sep 27, 2024

Conversation

bnewbold
Copy link
Collaborator

@bnewbold bnewbold requested a review from brianolson September 26, 2024 23:33
brianolson
brianolson approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, not omitempty, but it could be "l":null or "t":null

@bnewbold bnewbold merged commit 6d11dbf into main Sep 27, 2024
7 checks passed
@bnewbold bnewbold deleted the bnewbold/mst-minor-comment branch September 27, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianolson brianolson brianolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnewbold @brianolson