Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avatar to AccountMeta #779

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add avatar to AccountMeta #779

merged 3 commits into from
Nov 5, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Oct 29, 2024

smol change. couple of new rules need avatar cids. currently have to fetch from public api before the rule processes in a separate request which is meh, since we have the info here already.

@bnewbold
Copy link
Collaborator

I think I was originally worried about redis cache size?

all the AccountMeta gets serialized/deserialized using some magic in the redis caching library we use. maybe we should take just the avatar CID as a string and include that? how much metadata about the avatar do you need for your rule? eg, might want banner also if looking for impersonation signals.

or, in the other direction, just include the entire profile view?

@haileyok
Copy link
Contributor Author

haileyok commented Oct 29, 2024

ah, didn't realize that. grabbing just the cid would be fine and i have a little function for that already. let me move that over to this pr. (along with the banner while we're at it, makes sense to do both here even though not needed atm)

@bnewbold bnewbold merged commit fc4b12c into main Nov 5, 2024
7 checks passed
@bnewbold bnewbold deleted the hailey/add-avatar-meta branch November 5, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants