Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexgen: handle 'ref' as procedure input type #788

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

bnewbold
Copy link
Collaborator

@bnewbold bnewbold commented Nov 5, 2024

This tries to resolve the situation discovered in #785, with the ozone "upsertSet" procedure.

That lexicon specifies the input schema via reference, instead of an "object" schema in-place.

This code could use real review, I just banged on it until it worked for the current lexicon.

@bnewbold bnewbold mentioned this pull request Nov 5, 2024
Copy link
Contributor

@brianolson brianolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnewbold bnewbold merged commit d1686e9 into main Nov 5, 2024
7 checks passed
@bnewbold bnewbold deleted the bnewbold/lexgen-input-ref branch November 5, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants