✨ Change label selector from searchable dropdown to clickable buttons #110
Conversation
foysalit
commented
May 1, 2024
•
foysalit
commented
- Change the label form to use clickable buttons instead of searchable dropdown. The searchable dropdown package has been removed as dependency. Labels can still be searched and custom labels can be added.
- Add cypress tests around the label add/remove and search behavior.
- Refactor cypress test code to make them more shareable.
|
Your Render PR Server URL is https://ozone-staging-pr-110.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cop3k1u3e1ms73bq9l1g. |
|
Your Render PR Server URL is https://ozone-sandbox-pr-110.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cop3k363e1ms73bq9lag. |
| @@ -15,6 +15,7 @@ export const Dropdown = ({ | |||
| children, | |||
| items, | |||
| containerClassName, | |||
| ...rest | |||
There was a problem hiding this comment.
This allows us to pass params like data-cy to the wrapper component/
| @@ -375,7 +375,7 @@ const EventFilterPanel = ({ | |||
| type="datetime-local" | |||
| id="createdAfter" | |||
| name="createdAfter" | |||
| className="block w-full" | |||
| className="block w-full dark:[color-scheme:dark]" | |||
There was a problem hiding this comment.
The date picker, by default, adds a calendar icon in the input field. This classname ensures that the icon's color changes based on the browser's scheme.
| }) | ||
| } | ||
| /> | ||
| {Object.keys(reasonTypeOptions).map((typeValue) => { |
There was a problem hiding this comment.
Move the report type selector from searchable dropdown to clickable buttons just like labels.
|
|
||
| export default defineConfig({ | ||
| e2e: { | ||
| setupNodeEvents(on, config) { | ||
| // implement node event listeners here | ||
| on('before:browser:launch', (browser, launchOptions) => { |
There was a problem hiding this comment.
Make sure the browser window is reasonably wide and tall enough so that tests can run without scrolling too much.
foysalit
changed the title
