♻️ Refactor the tabs component to be reused #113
Conversation
|
Your Render PR Server URL is https://ozone-staging-pr-113.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coqfisn79t8c73cakg90. |
|
Your Render PR Server URL is https://ozone-sandbox-pr-113.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coqfit779t8c73cakgf0. |
components/shell/MobileMenu.tsx
Outdated
| if (item.serviceAccountOnly && !isServiceAccount) { | ||
| return | ||
| } | ||
| const Icon = ICONS[item.icon] |
There was a problem hiding this comment.
Does this end up showing the "Configure" nav item to non-service accounts? The main issue there is that only the service account has the ability to modify their service record, so it wont have the intended effect if another user does it.
There was a problem hiding this comment.
(There's also similar logic in SidebarNav.tsx)
There was a problem hiding this comment.
oh this wasn't meant to be committed. cleaned up.
components/common/Tabs.tsx
Outdated
| const Tab = ({ | ||
| view, | ||
| label, | ||
| sublabel, | ||
| }: { |
There was a problem hiding this comment.
Defining a component anonymously like this has a quirk, which is that it always fully unmounts and remounts on render. I'd recommend just pulling this out into its own component outside of Tabs render function.
This is a simple refactor of the existing tabs components that was just copy pasted across various pages.