✨ Show post preview even when moderator is blocked by the author #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://ozone-staging-pr-114.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cosh936d3nmc73f3kjb0. |
|
Your Render PR Server URL is https://ozone-sandbox-pr-114.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cosh93ud3nmc73f3kjgg. |
devinivy
reviewed
May 6, 2024
Comment on lines
228
to
234
| } else if (Array.isArray(item.post.labels?.['values'])) { | ||
| // This handles the case where the item may be built from raw record and in that case, labels value is not an array rather a self label object | ||
| const labels = item.post.labels?.['values'] as unknown as Array<{ | ||
| val: string | ||
| }> | ||
| labels.forEach(({ val }) => labelVals.push(val)) | ||
| } |
There was a problem hiding this comment.
Rather than passing a raw record here and deviating in this way from the expected, valid FeedViewPost type, I wonder if it may be friendlier to instead build the labels object on the other side and avoid this special case on the consumer side.
Might look something like:
if (data?.thread?.blocked) {
return (
<BaseRecordCard
uri={uri}
renderRecord={(record) => (
<PostAsCard
dense
controls={false}
item={{
post: {
uri: record.uri,
cid: record.cid,
author: record.repo,
record: record.value,
labels: isSelfLabels(record.value['labels'])
? record.value['labels'].values.map(({ val }) => ({
val,
uri: record.uri,
src: record.repo.did,
cts: new Date(0).toISOString(),
}))
: [],
indexedAt: new Date(0).toISOString(),
},
}}
/>
)}
/>
)
}There was a problem hiding this comment.
yeah that looks cleaner, thanks!
devinivy
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
getPostThreaddoes not return post record data when there's a block relationship between author and the moderator viewer, this PR builds the post data fromgetRecordso that post preview is displayed properly in the quick action panel.