✨ Show search results when searching by email: prefix #136
Conversation
|
Your Render PR Server URL is https://ozone-staging-pr-136.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpov2bdds78s73a2rsfg. |
|
Your Render PR Server URL is https://ozone-sandbox-pr-136.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpov2c5ds78s73a2rso0. |
| }) | ||
|
|
||
| await Promise.allSettled( | ||
| data.accounts.map(async (account) => { |
There was a problem hiding this comment.
This is kinda resource intensive since we're essentially firing like 25 api reqs to getRepo but this isn't expected to be a commonly used feature so we should be fine with some overhead.
| await Promise.allSettled( | ||
| data.accounts.map(async (account) => { |
There was a problem hiding this comment.
Without handling the result of allSettled() this will swallow errors, including unexpected ones. Another option is to use Promise.all() here and handle expected error conditions within each item.
There was a problem hiding this comment.
This is intentional, I think we have most info we need to render a partial view from the resultSet so if some requests fail, they will just not show the augmented data from getRepo()
There was a problem hiding this comment.
That totally makes sense and I don't think we'd need to change that— my main question is whether we want to swallow all errors versus ignore some acceptable set of errors and log or throw the rest. For example, a logic bug could cause a TypeError in here and there's no way we'd be able to observe it, could easily go unnoticed.
There was a problem hiding this comment.
The rule here might be that we're comfy ignoring all XRPCErrors, for example. I really appreciate libraries like bounce (though I think this may catered to server-side) which ensure developer/system errors don't get missed when permitting some errors.
No description provided.