Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add starterpack support #137

Merged
merged 2 commits into from
Jun 25, 2024
Merged

✨ Add starterpack support #137

merged 2 commits into from
Jun 25, 2024

Conversation

foysalit
Copy link
Contributor

Screen.Recording.2024-06-22.at.01.55.58.mov

Copy link

render bot commented Jun 21, 2024

Copy link

render bot commented Jun 21, 2024

@foysalit foysalit requested a review from devinivy June 21, 2024 23:57
Comment on lines 26 to 31
if (parsed.collection === CollectionId.FeedGenerator) {
return <FeedGeneratorRecordCard uri={uri} />
}
if (parsed.collection === CollectionId.FeedGenerator) {
return <FeedGeneratorRecordCard uri={uri} />
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (parsed.collection === CollectionId.FeedGenerator) {
return <FeedGeneratorRecordCard uri={uri} />
}
if (parsed.collection === CollectionId.FeedGenerator) {
return <FeedGeneratorRecordCard uri={uri} />
}
if (parsed.collection === CollectionId.FeedGenerator) {
return <FeedGeneratorRecordCard uri={uri} />
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops copy paste.

const meta: string[] = [
`${joinedWeekCount} Joined last week`,
`${joinedAllTimeCount} Joined all time`,
`${feeds?.length || 'no'} Feed included`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`${feeds?.length || 'no'} Feed included`,
`${feeds?.length || 'No'} feed(s) included`,

</Link>
<span className="ml-1">by</span>
<Link href={`/repositories/${creator.did}`}>
<span className="ml-1 text-gray-500 dark:text-gra-50">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span className="ml-1 text-gray-500 dark:text-gra-50">
<span className="ml-1 text-gray-500 dark:text-gray-50">

Comment on lines 98 to 99
<div className="pb-2 pl-10">
{!!feeds?.length && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah totally forgot about this! Not a blocking issue, but another thing we may want to show is the og card preview of the starter pack. It would be useful for mods to see if it contains an inappropriate avatar image, or something along those lines. They live at https://ogcard.cdn.bsky.app/start/{did}/{rkey}. E.g. https://ogcard.cdn.bsky.app/start/did:plc:ragtjsm2j2vknwkz3zp4oxrd/3kvaqmutnga2z

@@ -12,6 +12,7 @@ import { ProfileAvatar } from '@/repositories/ProfileAvatar'
import { ShieldCheckIcon } from '@heroicons/react/24/solid'
import { ProfileViewDetailed } from '@atproto/api/dist/client/types/app/bsky/actor/defs'
import { isSelfLabels } from '@atproto/api/dist/client/types/com/atproto/label/defs'
import { StarterPackRecordCard } from './srtarterpacks/RecordCard'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologise for jumping in here, I just wanted to flag the typo in the path here in case it's an issue: './srtarterpacks/RecordCard'

package.json Outdated
@@ -17,7 +17,7 @@
"e2e:run": "$(yarn bin)/cypress run"
},
"dependencies": {
"@atproto/api": "^0.12.17",
"@atproto/api": "0.12.21-next.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can update to 0.12.22 now 👍

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are just some minor tweaks, otherwise looking great!

@foysalit foysalit requested a review from devinivy June 25, 2024 16:54
@foysalit foysalit merged commit 11f3127 into main Jun 25, 2024
3 checks passed
@matthieusieben matthieusieben deleted the starterpack branch November 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants