-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add starterpack support #137
Conversation
Your Render PR Server URL is https://ozone-staging-pr-137.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpr16so8fa8c73dgc5q0. |
Your Render PR Server URL is https://ozone-sandbox-pr-137.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpr16tg8fa8c73dgc650. |
components/common/RecordCard.tsx
Outdated
if (parsed.collection === CollectionId.FeedGenerator) { | ||
return <FeedGeneratorRecordCard uri={uri} /> | ||
} | ||
if (parsed.collection === CollectionId.FeedGenerator) { | ||
return <FeedGeneratorRecordCard uri={uri} /> | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (parsed.collection === CollectionId.FeedGenerator) { | |
return <FeedGeneratorRecordCard uri={uri} /> | |
} | |
if (parsed.collection === CollectionId.FeedGenerator) { | |
return <FeedGeneratorRecordCard uri={uri} /> | |
} | |
if (parsed.collection === CollectionId.FeedGenerator) { | |
return <FeedGeneratorRecordCard uri={uri} /> | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops copy paste.
const meta: string[] = [ | ||
`${joinedWeekCount} Joined last week`, | ||
`${joinedAllTimeCount} Joined all time`, | ||
`${feeds?.length || 'no'} Feed included`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`${feeds?.length || 'no'} Feed included`, | |
`${feeds?.length || 'No'} feed(s) included`, |
</Link> | ||
<span className="ml-1">by</span> | ||
<Link href={`/repositories/${creator.did}`}> | ||
<span className="ml-1 text-gray-500 dark:text-gra-50"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span className="ml-1 text-gray-500 dark:text-gra-50"> | |
<span className="ml-1 text-gray-500 dark:text-gray-50"> |
<div className="pb-2 pl-10"> | ||
{!!feeds?.length && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah totally forgot about this! Not a blocking issue, but another thing we may want to show is the og card preview of the starter pack. It would be useful for mods to see if it contains an inappropriate avatar image, or something along those lines. They live at https://ogcard.cdn.bsky.app/start/{did}/{rkey}
. E.g. https://ogcard.cdn.bsky.app/start/did:plc:ragtjsm2j2vknwkz3zp4oxrd/3kvaqmutnga2z
components/common/RecordCard.tsx
Outdated
@@ -12,6 +12,7 @@ import { ProfileAvatar } from '@/repositories/ProfileAvatar' | |||
import { ShieldCheckIcon } from '@heroicons/react/24/solid' | |||
import { ProfileViewDetailed } from '@atproto/api/dist/client/types/app/bsky/actor/defs' | |||
import { isSelfLabels } from '@atproto/api/dist/client/types/com/atproto/label/defs' | |||
import { StarterPackRecordCard } from './srtarterpacks/RecordCard' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologise for jumping in here, I just wanted to flag the typo in the path here in case it's an issue: './srtarterpacks/RecordCard'
package.json
Outdated
@@ -17,7 +17,7 @@ | |||
"e2e:run": "$(yarn bin)/cypress run" | |||
}, | |||
"dependencies": { | |||
"@atproto/api": "^0.12.17", | |||
"@atproto/api": "0.12.21-next.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can update to 0.12.22
now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are just some minor tweaks, otherwise looking great!
Screen.Recording.2024-06-22.at.01.55.58.mov