✨ Show embedded list in post card #138
Conversation
foysalit
commented
Jun 26, 2024
•
foysalit
commented
> After
|
Your Render PR Server URL is https://ozone-staging-pr-138.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpu9hfiju9rs73fbq6o0. |
|
Your Render PR Server URL is https://ozone-sandbox-pr-138.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpu9hg2ju9rs73fbq6u0. |
| did: `${did}`, | ||
| rkey: `${rkey}`, |
There was a problem hiding this comment.
Is this a way of casting did and rkey into a string? If so, could it end-up casting them to something we don't intend like 'null' or 'undefined'?
There was a problem hiding this comment.
record.uri is always present and parsing the uri should always return did and rkey for isViewBlocked AFAICT so this is just appeasing the ts linter.
| <ProfileAvatar | ||
| profile={{ | ||
| avatar: embed.record.avatar, | ||
| did: embed.record.creator.did, | ||
| handle: embed.record.name, | ||
| }} | ||
| className="w-6 h-6 rounded-full" | ||
| /> |
There was a problem hiding this comment.
Would it be worth renaming the ProfileAvatar component or extracting out a more generic component from it? I notice that we're "tricking" it into thinking it's displaying profile information.
There was a problem hiding this comment.
hmm.. idk, it's minimal lift but I also don't see avatars being shown for anything other than users/profiles so don't think it it matters a lot either way?
| <> | ||
| <span className="font-bold">{embed.record.name}</span> | ||
| </> |
There was a problem hiding this comment.
We should be able to get rid of this fragment.
|
I don't disagree strongly with any of the suggestions above so might end up making those changes in a future iteration but don't think any of those are blockers so going to ahead and merge. |
