🚧 Set list viewer and editor #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://ozone-staging-pr-163.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr14eqrtq21c73bpa4tg. |
devinivy
approved these changes
Aug 20, 2024
arcalinea
had a problem deploying
to
sets - ozone-staging PR #163
Render
Failure
arcalinea
had a problem deploying
to
sets - ozone-staging PR #163
Render
Failure
arcalinea
temporarily deployed
to
sets - ozone-staging PR #163
Render
Destroyed
devinivy
reviewed
Oct 14, 2024
| @@ -0,0 +1,9 @@ | |||
| export const createSetPageLink = (queryParams: Record<string, string>) => { | |||
| const url = new URL(window.location.href.replace(window.location.search, '')) | |||
There was a problem hiding this comment.
Does the base URL need to be dynamic like this? Could it look something like:
const searchParams = new URLSearchParams()
Object.entries({ tab: 'sets', ...queryParams }).forEach(([key, value]) => {
searchParams.set(key, value)
})
return `/base/page/path?${searchParams.toString()}`There was a problem hiding this comment.
yeah there's at least one place where we want to navigate to a nested view while maintaining the parent view so this is the safest way of making sure that we don't lose parent view because of param change.
devinivy
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-09-19.at.20.58.45.mov