✨ Add can't send email warning for users that can not receiv… #176
Conversation
foysalit
commented
Sep 4, 2024
foysalit
commented
…e-email-based-on-pds
|
Your Render PR Server URL is https://ozone-staging-pr-176.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-crcvkrhu0jms73en51og. |
| } | ||
|
|
||
| return DOMAINS_ALLOWING_EMAIL_COMMUNICATION.some((domain) => { | ||
| return pdsEndpoint.endsWith(domain) |
There was a problem hiding this comment.
We probably want the domain to end with .bsky.network rather than bsky.network.
There was a problem hiding this comment.
makes sense. but since this is env var, we can just configure it that way in the var, right? maybe the name needs an adjustment so that it's not DOMAINS_ALLOWING_EMAIL_COMMUNICATION and instead DOMAINS_SUFFIXES_ALLOWING_EMAIL_COMMUNICATION?
There was a problem hiding this comment.
@devinivy do lmk if you have thoughts on this, I'll merge for now and happy to address any different outcome from this as a fast follow.
There was a problem hiding this comment.
Yup we can just configure it that way 👍
lib/constants.ts
Outdated
| export const DOMAINS_ALLOWING_EMAIL_COMMUNICATION = ( | ||
| process.env.NEXT_PUBLIC_DOMAINS_ALLOWING_EMAIL_COMMUNICATION || 'bsky.network' |
There was a problem hiding this comment.
Perhaps we should default to empty, and configure this specially on our deployments— otherwise this will be the configuration in the distro.
arcalinea
temporarily deployed
to
disable-email-based-on-pds - ozone-staging PR #176
Render
Destroyed
