🐛 Show all labels in selector that can be edited by labeler #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
fix-self-and-label-conflict - ozone-staging PR #192
Render
Destroyed
devinivy
approved these changes
Sep 19, 2024
devinivy
reviewed
Sep 19, 2024
Comment on lines
-662
to
+665
| const isExternalLabel = allLabels.some((l) => { | ||
| return l.val === label && l.src !== config.did | ||
| // If there's a label where the source is the current labeler, it's editable | ||
| const isEditableLabel = allLabels.some((l) => { | ||
| return l.val === label && l.src === config.did | ||
| }) | ||
| return !isSelfLabel(label) && !isExternalLabel | ||
| return !isSelfLabel(label) && isEditableLabel |
There was a problem hiding this comment.
Is there any chance of isEditableLabel being true for a self-label? Perhaps this could be simplified down to just isEditableLabel.
There was a problem hiding this comment.
iirc, the selfLabel check prevents labels that look like porn(self) to show up in the selector so we would still want to filter those out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a user applies a self label
pornand automod also labels the post withporn, the label selector won't showpornas already selected because it thinkspornis a self label, hence, not removable. This PR fixes it.